Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P pspio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Electronic Structure Library
  • pspio
  • Merge requests
  • !36

Update UPF reader to accept new format with XML attributes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Damien Caliste requested to merge damien.caliste/pspio:upf2 into master Feb 26, 2018
  • Overview 8
  • Commits 2
  • Pipelines 2
  • Changes 4

Try to follow the file format description from QE website. Allow some value to be attributes of an XML element, like for PP_HEADER.

Tests are missing, will come later.

The way attributes are read is really ugly. The stream is rewind for each attribute… I didn't found any better way, without allocating memory to put part of the file into. I guess it will be fine because no so many attributes are poked. Well hopefully.

Edited Feb 26, 2018 by Damien Caliste
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: upf2